Ignore files with non-sane filenames in the Android stack symbolizing tool.

Ignore files with non-sane filenames in the Android stack symbolizing tool.

BUG=498683
Committed: https://crrev.com/04743335609114653560808dda22cb8b09e70670
Cr-Commit-Position: refs/heads/master@{#333798}

[Bernhard Bauer, 2015-06-10 16:25:20]

bauerb@chromium.org changed reviewers:
+ primiano@chromium.org, rmcilroy@chromium.org

[Bernhard Bauer, 2015-06-10 16:27:24]

Please review. Thanks!

[rmcilroy, 2015-06-10 17:24:59]

On 2015/06/10 16:27:24, Bernhard Bauer wrote:
> Please review. Thanks!

lgtm, thanks!

[Bernhard Bauer, 2015-06-10 17:27:55]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-06-10 17:28:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175033002/20001

[Primiano Tucci (use gerrit), 2015-06-10 17:37:11]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-06-10 17:37:19]

https://codereview.chromium.org/1175033002/diff/20001/third_party/android_pla...
File third_party/android_platform/development/scripts/symbol.py (right):

https://codereview.chromium.org/1175033002/diff/20001/third_party/android_pla...
third_party/android_platform/development/scripts/symbol.py:455: if not
os.path.splitext(symbols) in ['', '.so', '.apk']:
Hmm I think you want [1] here, this is going to skip everything:
splitext returns a tuple (name, ext)

>>> os.path.splitext('foo.bar')
('foo', '.bar')
>>> os.path.splitext('foo.bar') in ['.bar']
False
>>> os.path.splitext('foo.bar')[1] in ['.bar']
True

[Bernhard Bauer, 2015-06-10 17:40:03]

https://codereview.chromium.org/1175033002/diff/20001/third_party/android_pla...
File third_party/android_platform/development/scripts/symbol.py (right):

https://codereview.chromium.org/1175033002/diff/20001/third_party/android_pla...
third_party/android_platform/development/scripts/symbol.py:455: if not
os.path.splitext(symbols) in ['', '.so', '.apk']:
On 2015/06/10 17:37:19, Primiano Tucci wrote:
> Hmm I think you want [1] here, this is going to skip everything:
> splitext returns a tuple (name, ext)
> 
> >>> os.path.splitext('foo.bar')
> ('foo', '.bar')
> >>> os.path.splitext('foo.bar') in ['.bar']
> False
> >>> os.path.splitext('foo.bar')[1] in ['.bar']
> True

Durrr. Indeed! Done.

[Primiano Tucci (use gerrit), 2015-06-10 17:40:51]

LGTM

[Bernhard Bauer, 2015-06-10 20:35:25]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2015-06-10 20:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1175033002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2015-06-10 20:36:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175033002/40001

[commit-bot: I haz the power, 2015-06-10 21:06:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 21:07:12]

Patchset 3 (id:??) landed as
https://crrev.com/04743335609114653560808dda22cb8b09e70670
Cr-Commit-Position: refs/heads/master@{#333798}