third_party/android_platform/development/scripts/symbol.py - Issue 1175033002: Ignore files with non-sane filenames in the Android stack symbolizing tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_platform/development/scripts/symbol.py

Issue 1175033002: Ignore files with non-sane filenames in the Android stack symbolizing tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/android_platform/development/scripts/symbol.py

diff --git a/third_party/android_platform/development/scripts/symbol.py b/third_party/android_platform/development/scripts/symbol.py

index dcb0e775bffb807da6c3afca6f1c5e7a35ba87da..4cde7d965afa27a0a5fe33fe928e8804fd4b92c2 100755

--- a/third_party/android_platform/development/scripts/symbol.py

+++ b/third_party/android_platform/development/scripts/symbol.py

@@ -452,6 +452,9 @@ def CallAddr2LineForSet(lib, unique_addrs):

symbols = SYMBOLS_DIR + lib

+ if not os.path.splitext(symbols)[1] in ['', '.so', '.apk']:

+ return None

if not os.path.isfile(symbols):

return None

« no previous file with comments | « third_party/android_platform/README.chromium ('k') | no next file » | no next file with comments »