third_party/android_platform/README.chromium - Issue 1175033002: Ignore files with non-sane filenames in the Android stack symbolizing tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_platform/README.chromium

Issue 1175033002: Ignore files with non-sane filenames in the Android stack symbolizing tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/android_platform/README.chromium

diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium

index 192b9d669be58213ff740e05bd156f18d878af15..854a36b583258af0518de8ba7040f4b6e2ca6054 100644

--- a/third_party/android_platform/README.chromium

+++ b/third_party/android_platform/README.chromium

@@ -26,7 +26,8 @@ include, but are not limited to, the following:

Added memoization of addr2line and objdump.

Added option to change the amount of symbolization done.

Updated output directories to use environment variable.

-When calling addr2line, check the symbol is a file (and not a directory).

+When calling addr2line, check the symbol is a file that looks like it contains

+ symbols.

Added support for parsing LOG(FATAL) and DCHECK errors and their

stack traces, as emitted by src/base/debug/stack_trace_android.cc

Added support for finding symbols when library is loaded directly from the APK.

« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/symbol.py » ('j') | no next file with comments »