Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 11742015: Support MASM in MSBuild and Winja (Closed)

Created:
7 years, 11 months ago by Ryan Sleevi
Modified:
5 years ago
Reviewers:
bradn, scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Support MASM in MSBuild and Winja BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : With tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -53 lines) Patch
M pylib/gyp/generator/msvs.py View 1 20 chunks +50 lines, -29 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 2 chunks +3 lines, -5 lines 0 comments Download
M pylib/gyp/win_tool.py View 1 chunk +6 lines, -3 lines 0 comments Download
A test/win/gyptest-masm.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
A test/win/masm/dummyfunc-x64.asm View 1 1 chunk +18 lines, -0 lines 0 comments Download
A test/win/masm/dummyfunc-x86.asm View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + test/win/masm/hello.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
A + test/win/masm/masm.gyp View 1 1 chunk +21 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
Scott: How do you feel about this approach? This handles the VS2010+ when using the ...
7 years, 11 months ago (2013-01-03 00:33:42 UTC) #1
Ryan Sleevi
Oh, and tests forthcoming, provided the design is acceptable.
7 years, 11 months ago (2013-01-03 00:34:02 UTC) #2
scottmg
Looks fine to me with tests, but adding bradn as I'm not that familiar with ...
7 years, 11 months ago (2013-01-03 03:36:39 UTC) #3
Ryan Sleevi
scott, brad: Please take a look at patchset 2, which has been updated with tests. ...
7 years, 11 months ago (2013-01-07 02:10:17 UTC) #4
scottmg
7 years, 11 months ago (2013-01-07 16:17:20 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698