Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: pylib/gyp/win_tool.py

Issue 11742015: Support MASM in MSBuild and Winja (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: With tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/win/gyptest-masm.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/win_tool.py
diff --git a/pylib/gyp/win_tool.py b/pylib/gyp/win_tool.py
index 7b065736383caec169cf8df1163f99f59f4bf08e..2e2531669cc4f8cf63a8e212471f17ce25e11b90 100755
--- a/pylib/gyp/win_tool.py
+++ b/pylib/gyp/win_tool.py
@@ -148,11 +148,14 @@ class WinTool(object):
print line
return popen.returncode
- def ExecAsmWrapper(self, arch, *args):
+ def ExecAsmWrapper(self, arch, *flags):
"""Filter logo banner from invocations of asm.exe."""
env = self._GetEnv(arch)
- # MSVS doesn't assemble x64 asm files.
- if arch == 'environment.x64':
+ if arch == 'environment.x86':
+ args = ['ml', '/nologo'] + list(flags)
+ elif arch == 'environment.x64':
+ args = ['ml64', '/nologo'] + list(flags)
+ else:
return 0
popen = subprocess.Popen(args, shell=True, env=env,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/win/gyptest-masm.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698