Issue 1174153002: Rows in stocks app should have ink splashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174153002: Rows in stocks app should have ink splashes (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rows in stocks app should have ink splashes R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f46bb558ca16cf908e03fb8b97ce1640a828c159

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	sky/examples/stocks2/lib/stock_row.dart	View		1 chunk	+13 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1174153002/diff/1/sky/examples/stocks2/lib/stock_row.dart File sky/examples/stocks2/lib/stock_row.dart (right): https://codereview.chromium.org/1174153002/diff/1/sky/examples/stocks2/lib/stock_row.dart#newcode48 sky/examples/stocks2/lib/stock_row.dart:48: width: 1.0))), width:1.0 is the default

5 years, 6 months ago (2015-06-10 21:28:23 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-10 21:58:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f46bb558ca16cf908e03fb8b97ce1640a828c159 (presubmit successful).

Expand Messages | Collapse Messages