Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: sky/examples/stocks2/lib/stock_row.dart

Issue 1174153002: Rows in stocks app should have ink splashes (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks2/lib/stock_row.dart
diff --git a/sky/examples/stocks2/lib/stock_row.dart b/sky/examples/stocks2/lib/stock_row.dart
index 6df131c520f8334c705ffcb64cb409a495e37867..6af4944286fad858d30e126d797de231ee2899f7 100644
--- a/sky/examples/stocks2/lib/stock_row.dart
+++ b/sky/examples/stocks2/lib/stock_row.dart
@@ -36,15 +36,18 @@ class StockRow extends Component {
new FlexExpandingChild(new Text(changeInPrice), key: "changeInPrice")
];
- return new Container(
- padding: const EdgeDims(16.0, 16.0, 20.0, 16.0),
- height: kHeight, // TODO(hansmuller): This shouldn't be needed
- decoration: const BoxDecoration(
- backgroundColor: const sky.Color(0xFFFFFFFF),
- border: const Border(
- bottom: const BorderSide(
- color: const sky.Color(0xFFF4F4F4),
- width: 1.0))),
- child: new FlexContainer(children: children));
+ // TODO(hansmuller): An explicit |height| shouldn't be needed
+ return new InkWell(children: [
+ new Container(
+ padding: const EdgeDims(16.0, 16.0, 20.0, 16.0),
+ height: kHeight,
+ decoration: const BoxDecoration(
+ border: const Border(
+ bottom: const BorderSide(
+ color: const sky.Color(0xFFF4F4F4),
+ width: 1.0))),
Hixie 2015/06/10 21:28:22 width:1.0 is the default
+ child: new FlexContainer(children: children)
+ )
+ ]);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698