Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: sky/examples/stocks2/lib/stock_row.dart

Issue 1174153002: Rows in stocks app should have ink splashes (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 import 'package:sky/framework/components2/ink_well.dart'; 6 import 'package:sky/framework/components2/ink_well.dart';
7 import 'package:sky/framework/fn2.dart'; 7 import 'package:sky/framework/fn2.dart';
8 import 'package:sky/framework/rendering/flex.dart'; 8 import 'package:sky/framework/rendering/flex.dart';
9 import 'package:sky/framework/rendering/box.dart'; 9 import 'package:sky/framework/rendering/box.dart';
10 import 'package:sky/framework/theme/typography.dart' as typography; 10 import 'package:sky/framework/theme/typography.dart' as typography;
(...skipping 18 matching lines...) Expand all
29 new Container( 29 new Container(
30 child: new StockArrow(percentChange: stock.percentChange), 30 child: new StockArrow(percentChange: stock.percentChange),
31 margin: const EdgeDims.only(right: 5.0)), 31 margin: const EdgeDims.only(right: 5.0)),
32 new FlexExpandingChild(new Text(stock.symbol), flex: 2, key: "symbol"), 32 new FlexExpandingChild(new Text(stock.symbol), flex: 2, key: "symbol"),
33 // TODO(hansmuller): text-align: right 33 // TODO(hansmuller): text-align: right
34 new FlexExpandingChild(new Text(lastSale), key: "lastSale"), 34 new FlexExpandingChild(new Text(lastSale), key: "lastSale"),
35 // TODO(hansmuller): text-align: right, ${typography.black.caption}; 35 // TODO(hansmuller): text-align: right, ${typography.black.caption};
36 new FlexExpandingChild(new Text(changeInPrice), key: "changeInPrice") 36 new FlexExpandingChild(new Text(changeInPrice), key: "changeInPrice")
37 ]; 37 ];
38 38
39 return new Container( 39 // TODO(hansmuller): An explicit |height| shouldn't be needed
40 padding: const EdgeDims(16.0, 16.0, 20.0, 16.0), 40 return new InkWell(children: [
41 height: kHeight, // TODO(hansmuller): This shouldn't be needed 41 new Container(
42 decoration: const BoxDecoration( 42 padding: const EdgeDims(16.0, 16.0, 20.0, 16.0),
43 backgroundColor: const sky.Color(0xFFFFFFFF), 43 height: kHeight,
44 border: const Border( 44 decoration: const BoxDecoration(
45 bottom: const BorderSide( 45 border: const Border(
46 color: const sky.Color(0xFFF4F4F4), 46 bottom: const BorderSide(
47 width: 1.0))), 47 color: const sky.Color(0xFFF4F4F4),
48 child: new FlexContainer(children: children)); 48 width: 1.0))),
Hixie 2015/06/10 21:28:22 width:1.0 is the default
49 child: new FlexContainer(children: children)
50 )
51 ]);
49 } 52 }
50 } 53 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698