sky/sdk/lib/framework/components2/popup_menu.dart - Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/popup_menu.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/sdk/lib/framework/components2/fixed_height_scrollable.dart ('K') | « sky/sdk/lib/framework/components2/modal_overlay.dart ('k') | sky/sdk/lib/framework/components2/popup_menu_item.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/sdk/lib/framework/components2/popup_menu.dart

diff --git a/sky/sdk/lib/framework/components2/popup_menu.dart b/sky/sdk/lib/framework/components2/popup_menu.dart

index 760f0e2d4434093f2340b3aaa25f111a96fcf707..e11a528e2f1d50771657c7af6aefa15d57b3fa8c 100644

--- a/sky/sdk/lib/framework/components2/popup_menu.dart

+++ b/sky/sdk/lib/framework/components2/popup_menu.dart

@@ -60,9 +60,16 @@ class PopupMenu extends AnimatedComponent {

// onDidMount(_measureSize);

}

+ PopupMenuController controller;

List<List<UINode>> items;

int level;

- PopupMenuController controller;

+ void syncFields(PopupMenu source) {

+ controller = source.controller;

+ items = source.items;

+ level = source.level;

+ super.syncFields(source);

+ }

double _position;

// int _width;