Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu_item.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/popup_menu_item.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu_item.dart b/sky/sdk/lib/framework/components2/popup_menu_item.dart
index bf7d64d2757df67f590b1aa10672dee972efd4f6..f3fb84efc4f361d07a54a9d3c6641218012d892f 100644
--- a/sky/sdk/lib/framework/components2/popup_menu_item.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu_item.dart
@@ -11,6 +11,12 @@ class PopupMenuItem extends Component {
List<UINode> children;
double opacity;
+ void syncFields(PopupMenuItem source) {
+ children = source.children;
+ opacity = source.opacity;
+ super.syncFields(source);
+ }
+
UINode build() {
return new Container(
constraints: const BoxConstraints(minWidth: 112.0),

Powered by Google App Engine
This is Rietveld 408576698