Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: sky/sdk/lib/framework/components2/modal_overlay.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/modal_overlay.dart
diff --git a/sky/sdk/lib/framework/components2/modal_overlay.dart b/sky/sdk/lib/framework/components2/modal_overlay.dart
index 282ee126c4a2ce102a9cb76e46d9165ebdccd059..34ff954c07856bed91390a7947df1f58defa4732 100644
--- a/sky/sdk/lib/framework/components2/modal_overlay.dart
+++ b/sky/sdk/lib/framework/components2/modal_overlay.dart
@@ -18,6 +18,12 @@ class ModalOverlay extends Component {
List<UINode> children;
GestureEventListener onDismiss;
+ void syncFields(ModalOverlay source) {
+ children = source.children;
+ onDismiss = source.onDismiss;
+ super.syncFields(source);
+ }
+
UINode build() {
return new EventListenerNode(
new StackContainer(children: children),

Powered by Google App Engine
This is Rietveld 408576698