fixes #216, JSNumber members

fixes #216, JSNumber members

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/a79a5c5bad1453458ebcb5fd5a68782bb0df6bdd

[Jennifer Messerly, 2015-06-10 19:54:13]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-06-10 20:04:20]

lgtm with question

https://codereview.chromium.org/1173903003/diff/1/lib/runtime/dart/_intercept...
File lib/runtime/dart/_interceptors.js (right):

https://codereview.chromium.org/1173903003/diff/1/lib/runtime/dart/_intercept...
lib/runtime/dart/_interceptors.js:514: 'toString',
Do we need to change the dispatch on this in dart_runtime.js?  Should
dart.toString() call obj.toString() or obj[dartx.toString()]?  Similar for
hashCode, runtimeType?

[Jennifer Messerly, 2015-06-10 20:09:35]

https://codereview.chromium.org/1173903003/diff/1/lib/runtime/dart/_intercept...
File lib/runtime/dart/_interceptors.js (right):

https://codereview.chromium.org/1173903003/diff/1/lib/runtime/dart/_intercept...
lib/runtime/dart/_interceptors.js:514: 'toString',
On 2015/06/10 20:04:20, vsm wrote:
> Do we need to change the dispatch on this in dart_runtime.js?  Should
> dart.toString() call obj.toString() or obj[dartx.toString()]?  Similar for
> hashCode, runtimeType?

Yeah, was just chatting about that with Leaf ... it would certainly be simpler
to do that, because then Object wouldn't be a special case (except for the guard
against null).

Otherwise, we could fix how we generate these members, because things won't work
as is. Good catch!
Filed https://github.com/dart-lang/dev_compiler/issues/217

[Jennifer Messerly, 2015-06-10 20:46:27]

just sent a separate fix for that other issue. I'll rebase it on this one

[Jennifer Messerly, 2015-06-10 20:46:48]

Committed patchset #1 (id:1) manually as
a79a5c5bad1453458ebcb5fd5a68782bb0df6bdd (presubmit successful).