Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1173903003: fixes #216, JSNumber members (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 99ece9c88e0c5082292229f8b6284f56fb1168b7..a4f09d0a54d5bbdf4c8329ddb7e98a48f8358f35 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -569,15 +569,17 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
var name = classElem.name;
var body = <JS.Statement>[];
- if (jsPeerName != null) {
+ if (_extensionTypes.contains(classElem)) {
var dartxNames = [];
for (var m in methods) {
if (!m.isAbstract && !m.isStatic && m.element.isPublic) {
dartxNames.add(_elementMemberName(m.element, allowExtensions: false));
}
}
- body.add(js.statement('dart.defineExtensionNames(#)',
- [new JS.ArrayInitializer(dartxNames, multiline: true)]));
+ if (dartxNames.isNotEmpty) {
+ body.add(js.statement('dart.defineExtensionNames(#)',
+ [new JS.ArrayInitializer(dartxNames, multiline: true)]));
+ }
}
body.add(new JS.ClassDeclaration(cls));

Powered by Google App Engine
This is Rietveld 408576698