Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tool/input_sdk/private/js_number.dart

Issue 1173903003: fixes #216, JSNumber members (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/dart/_interceptors.js ('K') | « lib/src/codegen/js_codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/js_number.dart
diff --git a/tool/input_sdk/private/js_number.dart b/tool/input_sdk/private/js_number.dart
index 9d0b1b937310fa6f26e6ddb2df634c4975a68617..ced02db358b9ef666af8bdb1d48b3668134a56b8 100644
--- a/tool/input_sdk/private/js_number.dart
+++ b/tool/input_sdk/private/js_number.dart
@@ -343,6 +343,8 @@ class JSNumber extends Interceptor implements num {
*/
// TODO(jmesserly): for dev_compiler all numbers will get `int` members at
// runtime for dynamic dispatch. We can fix by checking it at dispatch time.
+// TODO(jmesserly): merge with JSNumber? That would simplify generated code,
+// and dart_runtime's extension mechanism.
@JsPeerInterface(name: 'Number')
class JSInt extends JSNumber implements int, double {
const JSInt();
« lib/runtime/dart/_interceptors.js ('K') | « lib/src/codegen/js_codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698