Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1173343006: Replace OFFSET_OF with offsetof as far as possible. (Closed)

Created:
5 years, 6 months ago by Sven Panne
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace OFFSET_OF with offsetof as far as possible. The remaining uses need some non-mechanical work: * non-standard-layout type, probably due to mixed access control * extended field designators Committed: https://crrev.com/d4f7bff1ea85376278ab9fba63a59e02ea35c68d Cr-Commit-Position: refs/heads/master@{#29071}

Patch Set 1 #

Patch Set 2 : Fixed typing chaos on ARM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+993 lines, -1000 lines) Patch
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/macros.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/global-handles.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 16 chunks +92 lines, -92 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 55 chunks +403 lines, -403 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 56 chunks +438 lines, -438 lines 0 comments Download
M test/cctest/test-assembler-ppc.cc View 6 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 6 months ago (2015-06-17 08:53:08 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-17 09:03:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173343006/20001
5 years, 6 months ago (2015-06-17 09:03:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 09:06:48 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 09:07:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4f7bff1ea85376278ab9fba63a59e02ea35c68d
Cr-Commit-Position: refs/heads/master@{#29071}

Powered by Google App Engine
This is Rietveld 408576698