Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/global-handles.cc

Issue 1173343006: Replace OFFSET_OF with offsetof as far as possible. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed typing chaos on ARM. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/deoptimizer.h ('k') | src/mips/simulator-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/global-handles.h" 8 #include "src/global-handles.h"
9 9
10 #include "src/vm-state-inl.h" 10 #include "src/vm-state-inl.h"
(...skipping 21 matching lines...) Expand all
32 FREE = 0, 32 FREE = 0,
33 NORMAL, // Normal global handle. 33 NORMAL, // Normal global handle.
34 WEAK, // Flagged as weak but not yet finalized. 34 WEAK, // Flagged as weak but not yet finalized.
35 PENDING, // Has been recognized as only reachable by weak handles. 35 PENDING, // Has been recognized as only reachable by weak handles.
36 NEAR_DEATH, // Callback has informed the handle is near death. 36 NEAR_DEATH, // Callback has informed the handle is near death.
37 NUMBER_OF_NODE_STATES 37 NUMBER_OF_NODE_STATES
38 }; 38 };
39 39
40 // Maps handle location (slot) to the containing node. 40 // Maps handle location (slot) to the containing node.
41 static Node* FromLocation(Object** location) { 41 static Node* FromLocation(Object** location) {
42 DCHECK(OFFSET_OF(Node, object_) == 0); 42 DCHECK(offsetof(Node, object_) == 0);
43 return reinterpret_cast<Node*>(location); 43 return reinterpret_cast<Node*>(location);
44 } 44 }
45 45
46 Node() { 46 Node() {
47 DCHECK(OFFSET_OF(Node, class_id_) == Internals::kNodeClassIdOffset); 47 DCHECK(offsetof(Node, class_id_) == Internals::kNodeClassIdOffset);
48 DCHECK(OFFSET_OF(Node, flags_) == Internals::kNodeFlagsOffset); 48 DCHECK(offsetof(Node, flags_) == Internals::kNodeFlagsOffset);
49 STATIC_ASSERT(static_cast<int>(NodeState::kMask) == 49 STATIC_ASSERT(static_cast<int>(NodeState::kMask) ==
50 Internals::kNodeStateMask); 50 Internals::kNodeStateMask);
51 STATIC_ASSERT(WEAK == Internals::kNodeStateIsWeakValue); 51 STATIC_ASSERT(WEAK == Internals::kNodeStateIsWeakValue);
52 STATIC_ASSERT(PENDING == Internals::kNodeStateIsPendingValue); 52 STATIC_ASSERT(PENDING == Internals::kNodeStateIsPendingValue);
53 STATIC_ASSERT(NEAR_DEATH == Internals::kNodeStateIsNearDeathValue); 53 STATIC_ASSERT(NEAR_DEATH == Internals::kNodeStateIsNearDeathValue);
54 STATIC_ASSERT(static_cast<int>(IsIndependent::kShift) == 54 STATIC_ASSERT(static_cast<int>(IsIndependent::kShift) ==
55 Internals::kNodeIsIndependentShift); 55 Internals::kNodeIsIndependentShift);
56 STATIC_ASSERT(static_cast<int>(IsPartiallyDependent::kShift) == 56 STATIC_ASSERT(static_cast<int>(IsPartiallyDependent::kShift) ==
57 Internals::kNodeIsPartiallyDependentShift); 57 Internals::kNodeIsPartiallyDependentShift);
58 } 58 }
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1226 blocks_[block][offset] = object; 1226 blocks_[block][offset] = object;
1227 if (isolate->heap()->InNewSpace(object)) { 1227 if (isolate->heap()->InNewSpace(object)) {
1228 new_space_indices_.Add(size_); 1228 new_space_indices_.Add(size_);
1229 } 1229 }
1230 *index = size_++; 1230 *index = size_++;
1231 } 1231 }
1232 1232
1233 1233
1234 } // namespace internal 1234 } // namespace internal
1235 } // namespace v8 1235 } // namespace v8
OLDNEW
« no previous file with comments | « src/deoptimizer.h ('k') | src/mips/simulator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698