Source/web/WebViewImpl.cpp - Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 9159d76f62c574e3e1bb7e0542557a4d3359220a..f6135aa3edfec3684a2dd06c4574713f70bb83df 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3365,7 +3365,7 @@ void WebViewImpl::resetScrollAndScaleState()

ScrollableArea* scrollableArea = frameView->layoutViewportScrollableArea();

if (scrollableArea->scrollPositionDouble() != DoublePoint::zero())

- scrollableArea->notifyScrollPositionChanged(DoublePoint::zero());

+ scrollableArea->setScrollPosition(DoublePoint::zero(), ProgrammaticScroll);

}

pageScaleConstraintsSet().setNeedsReset(true);

@@ -4233,7 +4233,7 @@ void WebViewImpl::applyViewportDeltas(

+ DoubleSize(layoutViewportDelta.width, layoutViewportDelta.height);

if (layoutViewport->scrollPositionDouble() != layoutViewportPosition) {

- layoutViewport->notifyScrollPositionChanged(layoutViewportPosition);

+ layoutViewport->setScrollPosition(layoutViewportPosition, CompositorScroll);

frameView->setWasScrolledByUser(true);

}

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/tests/PinchViewportTest.cpp » ('j') | no next file with comments »