Source/web/WebLocalFrameImpl.cpp - Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 5ff11eb2c8841e6ba60abd8408c39bdde947d64b..d5480e118b4c0fe31674aa84daac3640dad28b0e 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -695,7 +695,7 @@ WebSize WebLocalFrameImpl::maximumScrollOffset() const

void WebLocalFrameImpl::setScrollOffset(const WebSize& offset)

{

if (FrameView* view = frameView())

- view->notifyScrollPositionChanged(IntPoint(offset.width, offset.height));

+ view->setScrollPosition(IntPoint(offset.width, offset.height), ProgrammaticScroll);

}

WebSize WebLocalFrameImpl::contentsSize() const

« no previous file with comments | « Source/platform/scroll/ScrollableAreaTest.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »