Source/web/tests/PinchViewportTest.cpp - Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index 88230f4754579a5216296dc2b3a5b5b9e4f2cea0..96b9d0c734e021530c164d1ee3110bd7f05c13d3 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -920,7 +920,7 @@ TEST_F(PinchViewportTest, DISABLED_TestScrollFocusedNodeIntoRect)

EXPECT_FLOAT_POINT_EQ(FloatPoint(150, 200), pinchViewport.visibleRect().location());

// Try it again but with the page zoomed in

- frame()->view()->notifyScrollPositionChanged(IntPoint(0, 0));

+ frame()->view()->setScrollPosition(IntPoint(0, 0), ProgrammaticScroll);

webViewImpl()->resizePinchViewport(IntSize(500, 300));

pinchViewport.setLocation(FloatPoint(0, 0));

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | Source/web/tests/ScrollAnimatorNoneTest.cpp » ('j') | no next file with comments »