fixes #209, remove tree mutation from CodeChecker

fixes #209, remove tree mutation from CodeChecker

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/3acd63a6a4ebdde64c81da6a3d410b4b4b6fedd4

[Jennifer Messerly, 2015-06-08 21:52:29]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-06-08 23:31:51]

lgtm

https://codereview.chromium.org/1172453002/diff/1/lib/src/info.dart
File lib/src/info.dart (right):

https://codereview.chromium.org/1172453002/diff/1/lib/src/info.dart#newcode110
lib/src/info.dart:110: // TODO(jmesserly): better name for this? Coercion is
taken (above).
Perhaps CoercionInfo?  Particularly now that this is on-the-side info and then
turned into an actual Coercion later.

[Jennifer Messerly, 2015-06-08 23:51:37]

Thanks!

https://codereview.chromium.org/1172453002/diff/1/lib/src/info.dart
File lib/src/info.dart (right):

https://codereview.chromium.org/1172453002/diff/1/lib/src/info.dart#newcode110
lib/src/info.dart:110: // TODO(jmesserly): better name for this? Coercion is
taken (above).
On 2015/06/08 23:31:51, vsm wrote:
> Perhaps CoercionInfo?  Particularly now that this is on-the-side info and then
> turned into an actual Coercion later.

Nice, +1. Done.

https://codereview.chromium.org/1172453002/diff/20001/lib/src/testing.dart
File lib/src/testing.dart (left):

https://codereview.chromium.org/1172453002/diff/20001/lib/src/testing.dart#ol...
lib/src/testing.dart:263: while (p is Conversion) p = p.parent;
after renamed Conversion -> CoercionInfo, I noticed this code is now dead

[Jennifer Messerly, 2015-06-08 23:52:06]

Committed patchset #2 (id:20001) manually as
3acd63a6a4ebdde64c81da6a3d410b4b4b6fedd4 (presubmit successful).