lib/src/checker/rules.dart - Issue 1172453002: fixes #209, remove tree mutation from CodeChecker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/checker/rules.dart

Issue 1172453002: fixes #209, remove tree mutation from CodeChecker (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/checker/rules.dart

diff --git a/lib/src/checker/rules.dart b/lib/src/checker/rules.dart

index 033c5597e418fb3effa969e7062245b2f3d50836..090831d499ef5e172a67175200941e91f437a832 100644

--- a/lib/src/checker/rules.dart

+++ b/lib/src/checker/rules.dart

@@ -534,7 +534,6 @@ class DownwardsInference {

if (e is ParenthesizedExpression) {

return _inferParenthesizedExpression(e, t, errors);

}

- if (e is Conversion) return _inferExpression(e.node, t, errors);

if (rules.isSubTypeOf(rules.getStaticType(e), t)) return true;

if (cast && rules.getStaticType(e).isDynamic) {

annotateCastFromDynamic(e, t);