Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: lib/src/testing.dart

Issue 1172453002: fixes #209, remove tree mutation from CodeChecker (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/info.dart ('k') | tool/analyze.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/testing.dart
diff --git a/lib/src/testing.dart b/lib/src/testing.dart
index a5ae8b04ae6012215c036a3fcc3741eccf6d664b..590298ee75645270505619afe6b31ddf63a7b638 100644
--- a/lib/src/testing.dart
+++ b/lib/src/testing.dart
@@ -241,8 +241,7 @@ class _ErrorMarkerVisitor extends UnifyingAstVisitor {
while (comment.next != null) {
comment = comment.next;
}
- if (comment.end == token.offset &&
- _realParent(node).beginToken != token) {
+ if (comment.end == token.offset && node.parent.beginToken != token) {
var commentText = '$comment';
var start = commentText.lastIndexOf('/*');
var end = commentText.lastIndexOf('*/');
@@ -256,13 +255,6 @@ class _ErrorMarkerVisitor extends UnifyingAstVisitor {
}
return super.visitNode(node);
}
-
- /// Get the node's parent, ignoring fake conversion nodes.
- AstNode _realParent(AstNode node) {
- var p = node.parent;
- while (p is Conversion) p = p.parent;
Jennifer Messerly 2015/06/08 23:51:37 after renamed Conversion -> CoercionInfo, I notice
- return p;
- }
}
/// Describes an expected message that should be produced by the checker.
« no previous file with comments | « lib/src/info.dart ('k') | tool/analyze.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698