Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1171873003: [Mac] Add cocoa implementation for sidebar extension action support

Created:
5 years, 6 months ago by ltilve
Modified:
5 years, 3 months ago
CC:
chromium-reviews, ben6
Base URL:
https://chromium.googlesource.com/chromium/src.git@patch-b
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Add cocoa implementation for sidebar extension action support BUG=477424

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased patch set to 1169823005/#ps200001 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 5 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/sidebar_controller.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/sidebar_controller.mm View 1 2 1 chunk +197 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
ltilve
5 years, 6 months ago (2015-06-09 10:01:50 UTC) #2
Add the cocoa implementation for sidebar extension browser action support.

It depends on https://codereview.chromium.org/1169823005/

Powered by Google App Engine
This is Rietveld 408576698