Chromecast: move link-time decisions to inheritance-based Content*Client.

Chromecast: move link-time decisions to inheritance-based Content*Client.

R=halliwell@chromium.org,lcwu@chromium.org,slan@chromium.org
BUG=None

Committed: https://crrev.com/7c0343cfad781414997cd713ae5ae4c9cc1d1eb3
Cr-Commit-Position: refs/heads/master@{#334001}

[halliwell, 2015-06-10 15:56:49]

https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
File chromecast/renderer/key_systems_cast.h (left):

https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
chromecast/renderer/key_systems_cast.h:27: std::vector<::media::KeySystemInfo>*
key_systems_info);
This isn't needed any more?

[gunsch-google, 2015-06-10 15:58:50]

gunsch@google.com changed reviewers:
+ gunsch@google.com

[gunsch-google, 2015-06-10 15:58:51]

https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
File chromecast/renderer/key_systems_cast.h (left):

https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
chromecast/renderer/key_systems_cast.h:27: std::vector<::media::KeySystemInfo>*
key_systems_info);
On 2015/06/10 15:56:49, halliwell wrote:
> This isn't needed any more?

See internal CL. This is done by CastContentRendererClientInternal overriding
ContentRendererClient::AddKeySystems.

[halliwell, 2015-06-10 16:17:15]

On 2015/06/10 15:58:51, gunsch-google wrote:
>
https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
> File chromecast/renderer/key_systems_cast.h (left):
> 
>
https://codereview.chromium.org/1171303002/diff/1/chromecast/renderer/key_sys...
> chromecast/renderer/key_systems_cast.h:27:
std::vector<::media::KeySystemInfo>*
> key_systems_info);
> On 2015/06/10 15:56:49, halliwell wrote:
> > This isn't needed any more?
> 
> See internal CL. This is done by CastContentRendererClientInternal overriding
> ContentRendererClient::AddKeySystems.

Thanks, didn't see AddKeySystems was already in the base class - I was looking
for a line to add it.

lgtm.

[gunsch, 2015-06-10 16:20:34]

gunsch@chromium.org changed reviewers:
- gunsch@google.com

[slan, 2015-06-10 17:18:08]

lgtm

[gunsch, 2015-06-10 23:46:17]

@lcwu: PTAL (24-hour ping)

[lcwu1, 2015-06-11 17:24:07]

What is the reason for making this change? (I am fine with creating an internal
sub-class, but wanted to understand the motivating reasons for this change as it
could potentially incur a bit more run-time overhead. Also the code doesn't seem
to be too much cleaner than before as we still need to keep xxx_simple.cc
files.)

Commit message comment:

s/link based/link time based

(I had absolutely no idea what 'link-based' means before looking at the code.
:-))

[gunsch, 2015-06-11 18:39:53]

updated description and discussed rationale offline.

For more context, see the CL at https://codereview.chromium.org/1153173006/ and
the discussion on https://codereview.chromium.org/1168643004/ .

[lcwu1, 2015-06-11 18:40:43]

lgtm

[gunsch, 2015-06-11 18:42:24]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-06-11 18:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1171303002/1

[commit-bot: I haz the power, 2015-06-11 19:09:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-11 19:12:18]

Patchset 1 (id:??) landed as
https://crrev.com/7c0343cfad781414997cd713ae5ae4c9cc1d1eb3
Cr-Commit-Position: refs/heads/master@{#334001}