Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 1171303002: Chromecast: move link-time decisions to inheritance-based Content*Client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.h
diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h
index fa71076a0fb5c9e5c7bbeb0c7faced01c6e72d48..e18605f3d40350e73087911f7265b6961bf5c58a 100644
--- a/chromecast/browser/cast_content_browser_client.h
+++ b/chromecast/browser/cast_content_browser_client.h
@@ -49,17 +49,20 @@ class CastContentBrowserClient: public content::ContentBrowserClient {
~CastContentBrowserClient() override;
// Appends extra command line arguments before launching a new process.
- void PlatformAppendExtraCommandLineSwitches(base::CommandLine* command_line);
+ virtual void AppendExtraCommandLineSwitches(base::CommandLine* command_line);
- // Returns any BrowserMessageFilters from the platform implementation that
- // should be added when launching a new render process.
- std::vector<scoped_refptr<content::BrowserMessageFilter>>
- PlatformGetBrowserMessageFilters();
+ // Returns any BrowserMessageFilters that should be added when launching a
+ // new render process.
+ virtual std::vector<scoped_refptr<content::BrowserMessageFilter>>
+ GetBrowserMessageFilters();
+
+ // Provide an AudioManagerFactory instance for WebAudio playback.
+ virtual scoped_ptr<::media::AudioManagerFactory> CreateAudioManagerFactory();
#if !defined(OS_ANDROID)
// Creates a MediaPipelineDevice (CMA backend) for media playback, called
// once per media player instance.
- scoped_ptr<media::MediaPipelineDevice> PlatformCreateMediaPipelineDevice(
+ virtual scoped_ptr<media::MediaPipelineDevice> CreateMediaPipelineDevice(
const media::MediaPipelineDeviceParams& params);
#endif
@@ -135,8 +138,6 @@ class CastContentBrowserClient: public content::ContentBrowserClient {
GURL requesting_url,
int render_process_id);
- scoped_ptr<::media::AudioManagerFactory> PlatformCreateAudioManagerFactory();
-
#if !defined(OS_ANDROID)
// Returns the crash signal FD corresponding to the current process type.
int GetCrashSignalFD(const base::CommandLine& command_line);
« no previous file with comments | « no previous file | chromecast/browser/cast_content_browser_client.cc » ('j') | chromecast/renderer/key_systems_cast.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698