Chromecast: use CastContent{Browser,Renderer}Client as a base class.

Chromecast: use CastContent{Browser,Renderer}Client as a base class.

This will allow consolidating many current "link-time" implementations
into virtual methods in our ContentClient classes, which should both
provide increased clarity and eliminate frequent internal build breaks
due to lag between a new public feature and matching internal CLs.

See discussion on https://codereview.chromium.org/1168643004/.

R=halliwell@chromium.org,lcwu@chromium.org,byungchul@chromium.org
BUG=None

Committed: https://crrev.com/5e3e1a5ef2862ff4058931c46564a0da5c995770
Cr-Commit-Position: refs/heads/master@{#333151}

[halliwell, 2015-06-05 20:21:05]

On 2015/06/05 18:51:50, gunsch wrote:

lgtm % compile errors! :)

[byungchul, 2015-06-05 20:25:33]

https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
File chromecast/app/cast_main_delegate.h (right):

https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
chromecast/app/cast_main_delegate.h:47: CastContentRendererClient*
PlatformCreateCastRendererClient();
What would be pros and cons among:

CastMainDelegate::PlatformCreateCastBrowserClient()

vs

static CastContentBrowserClient::Create()

?

[byungchul, 2015-06-05 20:28:21]

https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
File chromecast/app/cast_main_delegate.h (right):

https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
chromecast/app/cast_main_delegate.h:47: CastContentRendererClient*
PlatformCreateCastRendererClient();
On 2015/06/05 20:25:33, byungchul wrote:
> What would be pros and cons among:
> 
> CastMainDelegate::PlatformCreateCastBrowserClient()
> 
> vs
> 
> static CastContentBrowserClient::Create()
> 
> ?

And, scoped_ptr<>

[gunsch, 2015-06-05 20:43:53]

On 2015/06/05 20:28:21, byungchul wrote:
>
https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
> File chromecast/app/cast_main_delegate.h (right):
> 
>
https://codereview.chromium.org/1153173006/diff/20001/chromecast/app/cast_mai...
> chromecast/app/cast_main_delegate.h:47: CastContentRendererClient*
> PlatformCreateCastRendererClient();
> On 2015/06/05 20:25:33, byungchul wrote:
> > What would be pros and cons among:
> > 
> > CastMainDelegate::PlatformCreateCastBrowserClient()
> > 
> > vs
> > 
> > static CastContentBrowserClient::Create()
> > 
> > ?
> 
> And, scoped_ptr<>

SGTM. Changed to ::Create and scoped_ptr<>. CastService::Create sets a
reasonable precedent here.

[byungchul, 2015-06-05 20:46:29]

lgtm

A nit

https://codereview.chromium.org/1153173006/diff/60001/chromecast/app/cast_mai...
File chromecast/app/cast_main_delegate.h (right):

https://codereview.chromium.org/1153173006/diff/60001/chromecast/app/cast_mai...
chromecast/app/cast_main_delegate.h:47: CastContentRendererClient*
PlatformCreateCastRendererClient();
Not necessary

[gunsch, 2015-06-05 21:01:40]

https://codereview.chromium.org/1153173006/diff/60001/chromecast/app/cast_mai...
File chromecast/app/cast_main_delegate.h (right):

https://codereview.chromium.org/1153173006/diff/60001/chromecast/app/cast_mai...
chromecast/app/cast_main_delegate.h:47: CastContentRendererClient*
PlatformCreateCastRendererClient();
On 2015/06/05 20:46:29, byungchul wrote:
> Not necessary

Done.

[gunsch, 2015-06-05 21:01:52]

gunsch@chromium.org changed reviewers:
+ alokp@chromium.org

[gunsch, 2015-06-05 21:02:00]

(+alokp)

[alokp, 2015-06-05 21:17:55]

lgtm

[gunsch, 2015-06-05 22:07:42]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-06-05 22:07:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, byungchul@chromium.org
Link to the patchset: https://codereview.chromium.org/1153173006/#ps80001
(title: "rm excess methods")

[commit-bot: I haz the power, 2015-06-05 22:09:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153173006/80001

[commit-bot: I haz the power, 2015-06-05 22:15:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-05 22:16:33]

Patchset 5 (id:??) landed as
https://crrev.com/5e3e1a5ef2862ff4058931c46564a0da5c995770
Cr-Commit-Position: refs/heads/master@{#333151}