Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -21 lines)			Patch
M	sky/sdk/lib/framework/animation/animated_value.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/animated_component.dart	View	2 chunks	+9 lines, -17 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/drawer.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/rendering/paragraph.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-09 22:24:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8fa9a3342a9d4eb220b58c18e96ad7a9888a83b5 (presubmit successful).