sky/sdk/lib/framework/components2/drawer.dart - Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/drawer.dart

Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/sdk/lib/framework/components2/animated_component.dart ('k') | sky/sdk/lib/framework/components2/popup_menu.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/sdk/lib/framework/components2/drawer.dart

diff --git a/sky/sdk/lib/framework/components2/drawer.dart b/sky/sdk/lib/framework/components2/drawer.dart

index b5bf630496ba2df9b4e0dfeff4756709755eddc4..f3400054d24c5a1e3c39b4bcc375e24cb2f61f2f 100644

--- a/sky/sdk/lib/framework/components2/drawer.dart

+++ b/sky/sdk/lib/framework/components2/drawer.dart

@@ -104,7 +104,9 @@ class Drawer extends AnimatedComponent {

this.children,

this.level: 0

}) : super(key: key) {

- animateField(controller.position, #_position);

+ animate(controller.position, (double value) {

+ _position = value;

+ });

}

UINode build() {

« no previous file with comments | « sky/sdk/lib/framework/components2/animated_component.dart ('k') | sky/sdk/lib/framework/components2/popup_menu.dart » ('j') | no next file with comments »