Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: sky/sdk/lib/framework/components2/animated_component.dart

Issue 1171273002: Move AnimatedComponent away from mirrors and towards a callback-based setter. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../animation/animated_value.dart'; 5 import '../animation/animated_value.dart';
6 import '../fn2.dart'; 6 import '../fn2.dart';
7 import 'dart:mirrors'; 7 import 'dart:async';
8
9 typedef void SetterFunction(double value);
8 10
9 abstract class AnimatedComponent extends Component { 11 abstract class AnimatedComponent extends Component {
12
10 AnimatedComponent({ Object key }) : super(key: key, stateful: true); 13 AnimatedComponent({ Object key }) : super(key: key, stateful: true);
11 14
12 var _debugAnimatedFields = new Set<Symbol>(); 15 animate(AnimatedValue value, SetterFunction setter) {
13 bool _debugIsNotYetAnimated(Symbol s) { 16 setter(value.value);
14 return _debugAnimatedFields.add(s); 17 StreamSubscription<double> subscription;
15 }
16
17 animateField(AnimatedValue value, Symbol symbol) {
18 // TODO(rafaelw): Assert symbol is present on |this|, is private and
19 // is over the same parameterized type as the animated value.
20 var mirror = reflect(this);
21 var subscription;
22
23 assert(_debugIsNotYetAnimated(symbol));
24 mirror.setField(symbol, value.value);
25
26 onDidMount(() { 18 onDidMount(() {
27 subscription = value.onValueChanged.listen((_) { 19 subscription = value.onValueChanged.listen((_) {
28 mirror.setField(symbol, value.value); 20 setter(value.value);
29 scheduleBuild(); 21 scheduleBuild();
30 }); 22 });
31 }); 23 });
32
33 onDidUnmount(() { 24 onDidUnmount(() {
34 if (subscription != null) { 25 if (subscription != null) {
35 subscription.cancel(); 26 subscription.cancel();
36 subscription = null; 27 subscription = null;
37 } 28 }
38 }); 29 });
39 } 30 }
31
40 } 32 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/framework/animation/animated_value.dart ('k') | sky/sdk/lib/framework/components2/drawer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698