Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: Source/core/dom/Touch.h

Issue 1170703003: Touch.identifier should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updating as per review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Touch.cpp » ('j') | Source/core/inspector/InspectorInputAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Touch.h
diff --git a/Source/core/dom/Touch.h b/Source/core/dom/Touch.h
index 8038088082db744476462ebd869c71aad1c6f8c6..b43b3879645c7e87ce3fbec10e222628db565002 100644
--- a/Source/core/dom/Touch.h
+++ b/Source/core/dom/Touch.h
@@ -45,7 +45,7 @@ class CORE_EXPORT Touch final : public RefCountedWillBeGarbageCollected<Touch>,
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<Touch> create(LocalFrame* frame, EventTarget* target,
- unsigned identifier, const FloatPoint& screenPos, const FloatPoint& pagePos,
+ int identifier, const FloatPoint& screenPos, const FloatPoint& pagePos,
const FloatSize& radius, float rotationAngle, float force)
{
return adoptRefWillBeNoop(
@@ -54,7 +54,7 @@ public:
// DOM Touch implementation
EventTarget* target() const { return m_target.get(); }
- unsigned identifier() const { return m_identifier; }
+ int identifier() const { return m_identifier; }
double clientX() const { return m_clientPos.x(); }
double clientY() const { return m_clientPos.y(); }
double screenX() const { return m_screenPos.x(); }
@@ -74,16 +74,16 @@ public:
DECLARE_TRACE();
private:
- Touch(LocalFrame* frame, EventTarget* target, unsigned identifier,
+ Touch(LocalFrame*, EventTarget*, int identifier,
const FloatPoint& screenPos, const FloatPoint& pagePos,
const FloatSize& radius, float rotationAngle, float force);
- Touch(EventTarget*, unsigned identifier, const FloatPoint& clientPos,
+ Touch(EventTarget*, int identifier, const FloatPoint& clientPos,
const FloatPoint& screenPos, const FloatPoint& pagePos,
const FloatSize& radius, float rotationAngle, float force, LayoutPoint absoluteLocation);
RefPtrWillBeMember<EventTarget> m_target;
- unsigned m_identifier;
+ int m_identifier;
// Position relative to the viewport in CSS px.
FloatPoint m_clientPos;
// Position relative to the screen in DIPs.
« no previous file with comments | « no previous file | Source/core/dom/Touch.cpp » ('j') | Source/core/inspector/InspectorInputAgent.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698