Source/core/inspector/InspectorInputAgent.cpp - Issue 1170703003: Touch.identifier should be long, not unsigned long

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInputAgent.cpp

Issue 1170703003: Touch.identifier should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating as per review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorInputAgent.cpp

diff --git a/Source/core/inspector/InspectorInputAgent.cpp b/Source/core/inspector/InspectorInputAgent.cpp

index 3945ed4bdd03743c5a75d1b8ce5ff6e37298c781..94e34776a8856f053f4f0cc98b6a6f80c3446143 100644

--- a/Source/core/inspector/InspectorInputAgent.cpp

+++ b/Source/core/inspector/InspectorInputAgent.cpp

@@ -50,7 +50,7 @@ namespace {

class SyntheticInspectorTouchPoint : public blink::PlatformTouchPoint {

public:

- SyntheticInspectorTouchPoint(unsigned id, State state, const blink::IntPoint& screenPos, const blink::IntPoint& pos, int radiusX, int radiusY, double rotationAngle, double force)

+ SyntheticInspectorTouchPoint(int id, State state, const blink::IntPoint& screenPos, const blink::IntPoint& pos, int radiusX, int radiusY, double rotationAngle, double force)

Rick Byers 2015/06/10 15:34:21 Good catch!

{

m_id = id;

m_screenPos = screenPos;

« no previous file with comments | « Source/core/dom/Touch.idl ('k') | Source/platform/PlatformTouchPoint.h » ('j') | no next file with comments »