Source/core/dom/Touch.cpp - Issue 1170703003: Touch.identifier should be long, not unsigned long

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Touch.cpp

Issue 1170703003: Touch.identifier should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating as per review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Touch.cpp

diff --git a/Source/core/dom/Touch.cpp b/Source/core/dom/Touch.cpp

index 7633d907261dbe431ba5ae5d0cb2b7d2c06ad73a..ad57293616162dd1ba5bf333a3d0d2f7a30a2d8d 100644

--- a/Source/core/dom/Touch.cpp

+++ b/Source/core/dom/Touch.cpp

@@ -44,7 +44,7 @@ static FloatPoint contentsOffset(LocalFrame* frame)

return FloatPoint(frameView->scrollPosition()).scaledBy(scale);

}

-Touch::Touch(LocalFrame* frame, EventTarget* target, unsigned identifier, const FloatPoint& screenPos, const FloatPoint& pagePos, const FloatSize& radius, float rotationAngle, float force)

+Touch::Touch(LocalFrame* frame, EventTarget* target, int identifier, const FloatPoint& screenPos, const FloatPoint& pagePos, const FloatSize& radius, float rotationAngle, float force)

: m_target(target)

, m_identifier(identifier)

, m_clientPos(pagePos - contentsOffset(frame))

@@ -58,7 +58,7 @@ Touch::Touch(LocalFrame* frame, EventTarget* target, unsigned identifier, const

m_absoluteLocation = roundedLayoutPoint(pagePos.scaledBy(scaleFactor));

}

-Touch::Touch(EventTarget* target, unsigned identifier, const FloatPoint& clientPos, const FloatPoint& screenPos, const FloatPoint& pagePos, const FloatSize& radius, float rotationAngle, float force, LayoutPoint absoluteLocation)

+Touch::Touch(EventTarget* target, int identifier, const FloatPoint& clientPos, const FloatPoint& screenPos, const FloatPoint& pagePos, const FloatSize& radius, float rotationAngle, float force, LayoutPoint absoluteLocation)

: m_target(target)

, m_identifier(identifier)

, m_clientPos(clientPos)

« no previous file with comments | « Source/core/dom/Touch.h ('k') | Source/core/dom/Touch.idl » ('j') | Source/core/inspector/InspectorInputAgent.cpp » ('J')