Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1169803004: Make __qems a CSSPrimitiveValue unit type (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make __qems a CSSPrimitiveValue unit type Make __qems a CSSPrimitiveValue unit type and remove the handling from CSSParserValue. This should make merging CSSParserValue into CSSParserToken a bit easier. BUG=489144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196941

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
rwlbuis
PTAL. I think this is still the best bug for it. Just a step in ...
5 years, 6 months ago (2015-06-08 22:10:09 UTC) #2
Timothy Loh
https://codereview.chromium.org/1169803004/diff/1/Source/core/css/CSSCalculationValue.cpp File Source/core/css/CSSCalculationValue.cpp (right): https://codereview.chromium.org/1169803004/diff/1/Source/core/css/CSSCalculationValue.cpp#newcode119 Source/core/css/CSSCalculationValue.cpp:119: case CSSPrimitiveValue::CSS_QEM: Might as well put this in the ...
5 years, 6 months ago (2015-06-10 00:55:04 UTC) #3
rwlbuis
On 2015/06/10 00:55:04, Timothy Loh wrote: > https://codereview.chromium.org/1169803004/diff/1/Source/core/css/CSSCalculationValue.cpp > File Source/core/css/CSSCalculationValue.cpp (right): > > https://codereview.chromium.org/1169803004/diff/1/Source/core/css/CSSCalculationValue.cpp#newcode119 ...
5 years, 6 months ago (2015-06-11 00:14:23 UTC) #4
Timothy Loh
On 2015/06/11 00:14:23, rwlbuis wrote: > On 2015/06/10 00:55:04, Timothy Loh wrote: > > > ...
5 years, 6 months ago (2015-06-11 00:17:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169803004/20001
5 years, 6 months ago (2015-06-11 00:22:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66142)
5 years, 6 months ago (2015-06-11 01:44:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169803004/20001
5 years, 6 months ago (2015-06-11 02:15:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66172)
5 years, 6 months ago (2015-06-11 03:17:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169803004/20001
5 years, 6 months ago (2015-06-11 10:15:41 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 11:55:21 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196941

Powered by Google App Engine
This is Rietveld 408576698