Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: Source/core/css/CSSCalculationValue.cpp

Issue 1169803004: Make __qems a CSSPrimitiveValue unit type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSPrimitiveValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 case CSSPrimitiveValue::CSS_RECT: 127 case CSSPrimitiveValue::CSS_RECT:
128 case CSSPrimitiveValue::CSS_RGBCOLOR: 128 case CSSPrimitiveValue::CSS_RGBCOLOR:
129 case CSSPrimitiveValue::CSS_PAIR: 129 case CSSPrimitiveValue::CSS_PAIR:
130 case CSSPrimitiveValue::CSS_SHAPE: 130 case CSSPrimitiveValue::CSS_SHAPE:
131 case CSSPrimitiveValue::CSS_QUAD: 131 case CSSPrimitiveValue::CSS_QUAD:
132 case CSSPrimitiveValue::CSS_CALC: 132 case CSSPrimitiveValue::CSS_CALC:
133 case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER: 133 case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER:
134 case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH: 134 case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH:
135 case CSSPrimitiveValue::CSS_PROPERTY_ID: 135 case CSSPrimitiveValue::CSS_PROPERTY_ID:
136 case CSSPrimitiveValue::CSS_VALUE_ID: 136 case CSSPrimitiveValue::CSS_VALUE_ID:
137 case CSSPrimitiveValue::CSS_QEM:
137 return false; 138 return false;
138 }; 139 };
139 ASSERT_NOT_REACHED(); 140 ASSERT_NOT_REACHED();
140 return false; 141 return false;
141 } 142 }
142 143
143 static String buildCSSText(const String& expression) 144 static String buildCSSText(const String& expression)
144 { 145 {
145 StringBuilder result; 146 StringBuilder result;
146 result.appendLiteral("calc"); 147 result.appendLiteral("calc");
(...skipping 611 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 return adoptRefWillBeNoop(new CSSCalcValue(expression, range)); 759 return adoptRefWillBeNoop(new CSSCalcValue(expression, range));
759 } 760 }
760 761
761 DEFINE_TRACE_AFTER_DISPATCH(CSSCalcValue) 762 DEFINE_TRACE_AFTER_DISPATCH(CSSCalcValue)
762 { 763 {
763 visitor->trace(m_expression); 764 visitor->trace(m_expression);
764 CSSValue::traceAfterDispatch(visitor); 765 CSSValue::traceAfterDispatch(visitor);
765 } 766 }
766 767
767 } // namespace blink 768 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSPrimitiveValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698