Source/core/css/CSSCalculationValue.cpp - Issue 1169803004: Make __qems a CSSPrimitiveValue unit type

Side by Side Diff: Source/core/css/CSSCalculationValue.cpp

Issue 1169803004: Make __qems a CSSPrimitiveValue unit type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 case CSSPrimitiveValue::CSS_HZ:	109 case CSSPrimitiveValue::CSS_HZ:

110 case CSSPrimitiveValue::CSS_KHZ:	110 case CSSPrimitiveValue::CSS_KHZ:

111 case CSSPrimitiveValue::CSS_VW:	111 case CSSPrimitiveValue::CSS_VW:

112 case CSSPrimitiveValue::CSS_VH:	112 case CSSPrimitiveValue::CSS_VH:

113 case CSSPrimitiveValue::CSS_VMIN:	113 case CSSPrimitiveValue::CSS_VMIN:

114 case CSSPrimitiveValue::CSS_VMAX:	114 case CSSPrimitiveValue::CSS_VMAX:

115 case CSSPrimitiveValue::CSS_DPPX:	115 case CSSPrimitiveValue::CSS_DPPX:

116 case CSSPrimitiveValue::CSS_DPI:	116 case CSSPrimitiveValue::CSS_DPI:

117 case CSSPrimitiveValue::CSS_DPCM:	117 case CSSPrimitiveValue::CSS_DPCM:

118 case CSSPrimitiveValue::CSS_FR:	118 case CSSPrimitiveValue::CSS_FR:

	119 case CSSPrimitiveValue::CSS_QEM:
	Timothy Loh 2015/06/10 00:55:03 Might as well put this in the return false branch, Might as well put this in the return false branch, we're never going to have calc with __qem
119 return true;	120 return true;

120 case CSSPrimitiveValue::CSS_UNKNOWN:	121 case CSSPrimitiveValue::CSS_UNKNOWN:

121 case CSSPrimitiveValue::CSS_CUSTOM_IDENT:	122 case CSSPrimitiveValue::CSS_CUSTOM_IDENT:

122 case CSSPrimitiveValue::CSS_STRING:	123 case CSSPrimitiveValue::CSS_STRING:

123 case CSSPrimitiveValue::CSS_URI:	124 case CSSPrimitiveValue::CSS_URI:

124 case CSSPrimitiveValue::CSS_IDENT:	125 case CSSPrimitiveValue::CSS_IDENT:

125 case CSSPrimitiveValue::CSS_ATTR:	126 case CSSPrimitiveValue::CSS_ATTR:

126 case CSSPrimitiveValue::CSS_COUNTER:	127 case CSSPrimitiveValue::CSS_COUNTER:

127 case CSSPrimitiveValue::CSS_RECT:	128 case CSSPrimitiveValue::CSS_RECT:

128 case CSSPrimitiveValue::CSS_RGBCOLOR:	129 case CSSPrimitiveValue::CSS_RGBCOLOR:

(...skipping 629 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
758 return adoptRefWillBeNoop(new CSSCalcValue(expression, range));	759 return adoptRefWillBeNoop(new CSSCalcValue(expression, range));

759 }	760 }

760	761

761 DEFINE_TRACE_AFTER_DISPATCH(CSSCalcValue)	762 DEFINE_TRACE_AFTER_DISPATCH(CSSCalcValue)

762 {	763 {

763 visitor->trace(m_expression);	764 visitor->trace(m_expression);

764 CSSValue::traceAfterDispatch(visitor);	765 CSSValue::traceAfterDispatch(visitor);

765 }	766 }

766	767

767 } // namespace blink	768 } // namespace blink

OLD	NEW

« no previous file with comments | « no previous file | Source/core/css/CSSPrimitiveValue.h » ('j') | Source/core/css/CSSPrimitiveValue.cpp » ('J')