Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1169493006: Invoke LeakSanitizer on teardown of RenderFrameImplTest (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invoke LeakSanitizer on teardown of RenderFrameImplTest Call LeakSanitizer before RenderViewTest::TearDown(), as the latter may leak WebKit objects when it shuts down V8. BUG=328552, 463143 TBR=jochen@chromium.org Committed: https://crrev.com/fd3d1531e7be69dfa36503fd2056fc438472e36f Cr-Commit-Position: refs/heads/master@{#333061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/renderer/render_frame_impl_browsertest.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sami
glider@, can you check if this fix makes sense? I basically followed the approach in ...
5 years, 6 months ago (2015-06-05 14:30:23 UTC) #2
rmcilroy
On 2015/06/05 14:30:23, Sami wrote: > glider@, can you check if this fix makes sense? ...
5 years, 6 months ago (2015-06-05 16:11:01 UTC) #3
Sami
Thanks Ross. TBR'ing this to unblock the timer refactoring patch.
5 years, 6 months ago (2015-06-05 16:13:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169493006/1
5 years, 6 months ago (2015-06-05 16:15:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 16:20:17 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:21:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd3d1531e7be69dfa36503fd2056fc438472e36f
Cr-Commit-Position: refs/heads/master@{#333061}

Powered by Google App Engine
This is Rietveld 408576698