Issue 187473004: Invoke LeakSanitizer on teardown of some browser test fixtures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187473004: Invoke LeakSanitizer on teardown of some browser test fixtures. (Closed)

Created:
6 years, 9 months ago by earthdok

Modified:
6 years, 9 months ago

Reviewers:
Fady Samuel, Paweł Hajdan Jr.

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Invoke LeakSanitizer on teardown of some browser test fixtures. Call LeakSanitizer before RenderViewTest::TearDown(), as the latter may leak WebKit objects when it shuts down V8. This call really belongs in RenderViewTest::TearDown(), but unfortunately there are unit tests which inherit from RenderViewTest, whereas this approach is only suitable for browser tests. Anyway this is intended as a temporary fix, as Oilpan is expected to rid us of those leaks. BUG=328552 TBR=phajdan.jr@chromium.org, fsamuel@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255016

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/test/base/chrome_render_view_test.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	content/renderer/browser_plugin/browser_plugin_browsertest.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/187473004/1

6 years, 9 months ago (2014-03-05 11:59:57 UTC) #3

Message was sent while issue was closed.

Change committed as 255016

Expand Messages | Collapse Messages