chrome/browser/extensions/chrome_extension_web_contents_observer.h - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/chrome_extension_function_details.cc ('K') | « chrome/browser/extensions/chrome_extension_function_details.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.h » ('j') | chrome/browser/extensions/tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_web_contents_observer.h

diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.h b/chrome/browser/extensions/chrome_extension_web_contents_observer.h

index e50119984f276013694c2a0775832242b3d10d18..a43842bb482b9152cabe8d8b262eca69fb26a0c9 100644

--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.h

+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.h

@@ -32,6 +32,9 @@ class ChromeExtensionWebContentsObserver

// content::WebContentsObserver overrides.

void RenderViewCreated(content::RenderViewHost* render_view_host) override;

+ // Silence a warning about hiding a virtual function.

+ using ExtensionWebContentsObserver::OnMessageReceived;

bool OnMessageReceived(const IPC::Message& message,

content::RenderFrameHost* render_frame_host) override;