Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "content/public/browser/web_contents_user_data.h" 10 #include "content/public/browser/web_contents_user_data.h"
(...skipping 14 matching lines...) Expand all
25 public content::WebContentsUserData<ChromeExtensionWebContentsObserver> { 25 public content::WebContentsUserData<ChromeExtensionWebContentsObserver> {
26 private: 26 private:
27 friend class content::WebContentsUserData<ChromeExtensionWebContentsObserver>; 27 friend class content::WebContentsUserData<ChromeExtensionWebContentsObserver>;
28 28
29 explicit ChromeExtensionWebContentsObserver( 29 explicit ChromeExtensionWebContentsObserver(
30 content::WebContents* web_contents); 30 content::WebContents* web_contents);
31 ~ChromeExtensionWebContentsObserver() override; 31 ~ChromeExtensionWebContentsObserver() override;
32 32
33 // content::WebContentsObserver overrides. 33 // content::WebContentsObserver overrides.
34 void RenderViewCreated(content::RenderViewHost* render_view_host) override; 34 void RenderViewCreated(content::RenderViewHost* render_view_host) override;
35
36 // Silence a warning about hiding a virtual function.
37 using ExtensionWebContentsObserver::OnMessageReceived;
35 bool OnMessageReceived(const IPC::Message& message, 38 bool OnMessageReceived(const IPC::Message& message,
36 content::RenderFrameHost* render_frame_host) override; 39 content::RenderFrameHost* render_frame_host) override;
37 40
38 // Adds a message to the extensions ErrorConsole. 41 // Adds a message to the extensions ErrorConsole.
39 void OnDetailedConsoleMessageAdded(const base::string16& message, 42 void OnDetailedConsoleMessageAdded(const base::string16& message,
40 const base::string16& source, 43 const base::string16& source,
41 const StackTrace& stack_trace, 44 const StackTrace& stack_trace,
42 int32 severity_level); 45 int32 severity_level);
43 46
44 // Reloads an extension if it is on the terminated list. 47 // Reloads an extension if it is on the terminated list.
45 void ReloadIfTerminated(content::RenderViewHost* render_view_host); 48 void ReloadIfTerminated(content::RenderViewHost* render_view_host);
46 49
47 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionWebContentsObserver); 50 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionWebContentsObserver);
48 }; 51 };
49 52
50 } // namespace extensions 53 } // namespace extensions
51 54
52 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 55 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_WEB_CONTENTS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698