Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Unified Diff: chrome/browser/extensions/chrome_extension_function_details.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_function_details.cc
diff --git a/chrome/browser/extensions/chrome_extension_function_details.cc b/chrome/browser/extensions/chrome_extension_function_details.cc
index d80c0812715fb793eb5156b810c32025a4f8c3ef..614511fcbb1f00a2ec65628ba84cabb33260da7d 100644
--- a/chrome/browser/extensions/chrome_extension_function_details.cc
+++ b/chrome/browser/extensions/chrome_extension_function_details.cc
@@ -54,7 +54,7 @@ Browser* ChromeExtensionFunctionDetails::GetCurrentBrowser() const {
// If the delegate has an associated browser, return it.
if (function_->dispatcher()) {
extensions::WindowController* window_controller =
- function_->dispatcher()->delegate()->GetExtensionWindowController();
+ function_->dispatcher()->GetExtensionWindowController();
not at google - send to devlin 2015/06/10 20:48:12 It would be nice if this were just function_->GetW
Devlin 2015/06/10 20:59:20 Agreed - I intend to try and clean up ExtensionFun
if (window_controller) {
Browser* browser = window_controller->GetBrowser();
if (browser)
@@ -93,7 +93,7 @@ ChromeExtensionFunctionDetails::GetExtensionWindowController() const {
// If the delegate has an associated window controller, return it.
if (function_->dispatcher()) {
extensions::WindowController* window_controller =
- function_->dispatcher()->delegate()->GetExtensionWindowController();
+ function_->dispatcher()->GetExtensionWindowController();
if (window_controller)
return window_controller;
}

Powered by Google App Engine
This is Rietveld 408576698