Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4552)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 0d614aa6ee88fcef58b79d19752a02b0ae3e09ec..4f661f87460a614a39e7e0a669317df99b94bd14 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -1245,7 +1245,7 @@ void DownloadsAcceptDangerFunction::PromptOrWait(int download_id, int retries) {
DownloadItem* download_item =
GetDownload(GetProfile(), include_incognito(), download_id);
content::WebContents* web_contents =
- dispatcher()->delegate()->GetVisibleWebContents();
+ dispatcher()->GetVisibleWebContents();
not at google - send to devlin 2015/06/10 18:37:49 I think this will fit on 1 line (and I would hope
Devlin 2015/06/10 20:59:20 Done.
if (InvalidId(download_item, &error_) ||
Fault(download_item->GetState() != DownloadItem::IN_PROGRESS,
errors::kNotInProgress, &error_) ||
@@ -1373,7 +1373,7 @@ bool DownloadsDragFunction::RunAsync() {
DownloadItem* download_item =
GetDownload(GetProfile(), include_incognito(), params->download_id);
content::WebContents* web_contents =
- dispatcher()->delegate()->GetVisibleWebContents();
+ dispatcher()->GetVisibleWebContents();
if (InvalidId(download_item, &error_) ||
Fault(!web_contents, errors::kInvisibleContext, &error_))
return false;
@@ -1482,7 +1482,7 @@ bool DownloadsGetFileIconFunction::RunAsync() {
DCHECK(icon_size == 16 || icon_size == 32);
float scale = 1.0;
content::WebContents* web_contents =
- dispatcher()->delegate()->GetVisibleWebContents();
+ dispatcher()->GetVisibleWebContents();
if (web_contents) {
scale = ui::GetScaleFactorForNativeView(
web_contents->GetRenderWidgetHostView()->GetNativeView());

Powered by Google App Engine
This is Rietveld 408576698