[turbofan] Allow ReplaceWithValue to kill control.

[turbofan] Allow ReplaceWithValue to kill control.

This allows any AdvancedReducer to remove exception projections from
graphs. This is the common case when JS-operators are being replaced
with pure values. The old NodeProperties::ReplaceWithValue is being
deprecated in favor of AdvancedReducer::ReplaceWithValue.

R=titzer@chromium.org
TEST=unittests/AdvancedReducerTest

Committed: https://crrev.com/8f4d9a0a1e5fc3b761409f851813831aad7dd53f
Cr-Commit-Position: refs/heads/master@{#28810}

[titzer, 2015-06-05 09:42:26]

https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):

https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer....
src/compiler/graph-reducer.h:126: GraphReducer(Graph* graph, Node* dead_value,
Node* dead_control, Zone* zone);
Can we move the zone first and then have default values for these arguments?

https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:416: : GraphReducer(js->graph(), dead_value(js),
dead_control(js), zone) {}
Why not just inline these private methods?

[Michael Starzinger, 2015-06-05 11:06:55]

Comments addressed.

https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):

https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer....
src/compiler/graph-reducer.h:126: GraphReducer(Graph* graph, Node* dead_value,
Node* dead_control, Zone* zone);
On 2015/06/05 09:42:26, titzer wrote:
> Can we move the zone first and then have default values for these arguments?

Done.

https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:416: : GraphReducer(js->graph(), dead_value(js),
dead_control(js), zone) {}
On 2015/06/05 09:42:26, titzer wrote:
> Why not just inline these private methods?

Done.

[titzer, 2015-06-05 11:30:50]

lgtm

https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-redu...
File src/compiler/graph-reducer.h (right):

https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-redu...
src/compiler/graph-reducer.h:174: Node* const dead_value_;
Const is like, just your opinion, man.

[Michael Starzinger, 2015-06-05 11:34:12]

https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-redu...
File src/compiler/graph-reducer.h (right):

https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-redu...
src/compiler/graph-reducer.h:174: Node* const dead_value_;
On 2015/06/05 11:30:50, titzer wrote:
> Const is like, just your opinion, man.

Done. Well, your slight preference is my command. :)

[Michael Starzinger, 2015-06-05 11:38:10]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-06-05 11:38:11]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1168693002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-06-05 11:38:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168693002/40001

[commit-bot: I haz the power, 2015-06-05 12:01:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 12:02:19]

Patchset 3 (id:??) landed as
https://crrev.com/8f4d9a0a1e5fc3b761409f851813831aad7dd53f
Cr-Commit-Position: refs/heads/master@{#28810}