test/unittests/compiler/js-type-feedback-unittest.cc - Issue 1168693002: [turbofan] Allow ReplaceWithValue to kill control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/js-type-feedback-unittest.cc

Issue 1168693002: [turbofan] Allow ReplaceWithValue to kill control. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/js-type-feedback-unittest.cc

diff --git a/test/unittests/compiler/js-type-feedback-unittest.cc b/test/unittests/compiler/js-type-feedback-unittest.cc

index 1bdcec27dc11f276012fb917ecb26e26cdf66d3e..93fd4953193fa680706b4239aa17ed554016071f 100644

--- a/test/unittests/compiler/js-type-feedback-unittest.cc

+++ b/test/unittests/compiler/js-type-feedback-unittest.cc

@@ -43,7 +43,7 @@ class JSTypeFeedbackTest : public TypedGraphTest {

JSGraph jsgraph(isolate(), graph(), common(), javascript(), &machine);

JSTypeFeedbackTable table(zone());

// TODO(titzer): mock the GraphReducer here for better unit testing.

- GraphReducer graph_reducer(graph(), zone());

+ GraphReducer graph_reducer(zone(), graph());

JSTypeFeedbackSpecializer reducer(&graph_reducer, &jsgraph, &table, nullptr,

global_object, mode, &dependencies_);

return reducer.Reduce(node);