Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/compiler/verifier.cc

Issue 1168693002: [turbofan] Allow ReplaceWithValue to kill control. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 66aeffa2b2b7c42ae2c32172fc6cc5fce0649f8c..59224539e9a3e3627d17cfbebbf11d1707ebd68c 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -194,7 +194,11 @@ void Verifier::Visitor::Check(Node* node) {
break;
case IrOpcode::kDead:
// Dead is never connected to the graph.
- UNREACHABLE();
+ // TODO(mstarzinger): Make the GraphReducer immediately perform control
+ // reduction in case control is killed. This will prevent {Dead} from
+ // being reachable after a phase finished. Then re-enable below assert.
+ // UNREACHABLE();
+ break;
case IrOpcode::kBranch: {
// Branch uses are IfTrue and IfFalse.
int count_true = 0, count_false = 0;
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698