LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js ('k') | LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

index 7b78db7972619b11d832e01c160e03741dfdd81c..ef8fd3a3d974d6929fdf25f8dcd727d9b9b4a1d3 100644

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

@@ -73,16 +73,16 @@ function testInherit()

parentElement.style.width = "800px";

parentElement.style.height = "600px";

parentElement.style.font = "10px Ahem"; // Used to resolve em font consistently.

- parentElement.style.gridTemplateColumns = "50px 1fr (last)";

- parentElement.style.gridTemplateRows = "2em (middle) 45px";

- testGridDefinitionsValues(parentElement, "50px 750px (last)", "20px (middle) 45px");

+ parentElement.style.gridTemplateColumns = "50px 1fr [last]";

+ parentElement.style.gridTemplateRows = "2em [middle] 45px";

+ testGridDefinitionsValues(parentElement, "50px 750px [last]", "20px [middle] 45px");

element = document.createElement("div");

parentElement.appendChild(element);

element.style.display = "grid";

element.style.gridTemplateColumns = "inherit";

element.style.gridTemplateRows = "inherit";

- testGridDefinitionsValues(element, "50px 0px (last)", "20px (middle) 45px");

+ testGridDefinitionsValues(element, "50px 0px [last]", "20px [middle] 45px");

document.body.removeChild(parentElement);

}

@@ -97,9 +97,9 @@ function testInitial()

element.style.display = "grid";

element.style.width = "800px";

element.style.height = "600px";

- element.style.gridTemplateColumns = "150% (middle) 55px";

- element.style.gridTemplateRows = "1fr (line) 2fr (line)";

- testGridDefinitionsValues(element, "1200px (middle) 55px", "200px (line) 400px (line)");

+ element.style.gridTemplateColumns = "150% [middle] 55px";

+ element.style.gridTemplateRows = "1fr [line] 2fr [line]";

+ testGridDefinitionsValues(element, "1200px [middle] 55px", "200px [line] 400px [line]");

element.style.gridTemplateColumns = "initial";

element.style.gridTemplateRows = "initial";