LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js ('k') | LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

index ac8b6b6f133f0e2694dbe8f8b32e6556c1793a5f..6b1757c8bd480747b39e4129c88067d6c24cb1df 100644

--- a/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

@@ -84,15 +84,15 @@ function testInherit()

{

var parentElement = document.createElement("div");

document.body.appendChild(parentElement);

- parentElement.style.gridTemplateColumns = "50px (last)";

- parentElement.style.gridTemplateRows = "(first) 101%";

+ parentElement.style.gridTemplateColumns = "50px [last]";

+ parentElement.style.gridTemplateRows = "[first] 101%";

element = document.createElement("div");

parentElement.appendChild(element);

element.style.gridTemplateColumns = "inherit";

element.style.gridTemplateRows = "inherit";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'50px (last)'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'(first) 101%'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'50px [last]'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'[first] 101%'");

document.body.removeChild(parentElement);

}

@@ -104,10 +104,10 @@ function testInitial()

{

element = document.createElement("div");

document.body.appendChild(element);

- element.style.gridTemplateColumns = "150% (last)";

- element.style.gridTemplateRows = "(first) 1fr";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'150% (last)'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'(first) 1fr'");

+ element.style.gridTemplateColumns = "150% [last]";

+ element.style.gridTemplateRows = "[first] 1fr";

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'150% [last]'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'[first] 1fr'");

element.style.gridTemplateColumns = "initial";

element.style.gridTemplateRows = "initial";