LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index e4f5ae6bd2af775dfe57d6a807b07a258af6ebbd..89ec3ce048114ce9155924d8b32f8961dc02a7aa 100644

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -102,8 +102,8 @@ function testInherit()

{

var parentElement = document.createElement("div");

document.body.appendChild(parentElement);

- parentElement.style.gridTemplateColumns = "50px (last)";

- parentElement.style.gridTemplateRows = "(first) 101%";

+ parentElement.style.gridTemplateColumns = "50px [last]";

+ parentElement.style.gridTemplateRows = "[first] 101%";

element = document.createElement("div");

parentElement.appendChild(element);

@@ -111,8 +111,8 @@ function testInherit()

element.style.height = "100px";

element.style.gridTemplateColumns = "inherit";

element.style.gridTemplateRows = "inherit";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'50px (last)'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'(first) 101px'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'50px [last]'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'[first] 101px'");

document.body.removeChild(parentElement);

}

@@ -127,10 +127,10 @@ function testInitial()

element.style.display = "grid";

element.style.width = "300px";

element.style.height = "150px";

- element.style.gridTemplateColumns = "150% (last)";

- element.style.gridTemplateRows = "(first) 1fr";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'450px (last)'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'(first) 150px'");

+ element.style.gridTemplateColumns = "150% [last]";

+ element.style.gridTemplateRows = "[first] 1fr";

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-columns')", "'450px [last]'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-template-rows')", "'[first] 150px'");

element.style.display = "grid";

element.style.gridTemplateColumns = "initial";