Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4421)

Unified Diff: chrome/browser/extensions/extension_view_host_factory.h

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_view_host_factory.h
diff --git a/chrome/browser/extensions/extension_view_host_factory.h b/chrome/browser/extensions/extension_view_host_factory.h
index 5bc388c38e6a555a3c34193662000e4c60a67831..f8e1e3750cacaf0f21a1897730c298eecbbfca69 100644
--- a/chrome/browser/extensions/extension_view_host_factory.h
+++ b/chrome/browser/extensions/extension_view_host_factory.h
@@ -28,6 +28,12 @@ class ExtensionViewHostFactory {
// hence only require a |profile|.
static ExtensionViewHost* CreateDialogHost(const GURL& url, Profile* profile);
+ // Creates a new ExtensionHost with its associated view, grouping it in the
+ // appropriate SiteInstance (and therefore process) based on the URL and
+ // profile.
+ static ExtensionViewHost* CreateSidebarHost(const GURL& url,
+ Browser* browser);
+
private:
DISALLOW_COPY_AND_ASSIGN(ExtensionViewHostFactory);
};
« no previous file with comments | « chrome/browser/extensions/extension_view_host.cc ('k') | chrome/browser/extensions/extension_view_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698