Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_view_host_factory.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_view_host_factory.h ('k') | chrome/browser/extensions/sidebar_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_view_host_factory.cc
diff --git a/chrome/browser/extensions/extension_view_host_factory.cc b/chrome/browser/extensions/extension_view_host_factory.cc
index d98b2b704424aa50a7a6b2fb980cba39117893ac..4f88f2fd2a0fe41eae6f068e421775ded44943df 100644
--- a/chrome/browser/extensions/extension_view_host_factory.cc
+++ b/chrome/browser/extensions/extension_view_host_factory.cc
@@ -113,4 +113,13 @@ ExtensionViewHost* ExtensionViewHostFactory::CreateDialogHost(
return CreateViewHost(url, profile, NULL, VIEW_TYPE_EXTENSION_DIALOG);
}
+// static
+ExtensionViewHost* ExtensionViewHostFactory::CreateSidebarHost(
+ const GURL& url,
+ Browser* browser) {
+ DCHECK(browser);
+ return CreateViewHost(url, browser->profile(), browser,
+ VIEW_TYPE_EXTENSION_SIDEBAR);
+}
+
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/extension_view_host_factory.h ('k') | chrome/browser/extensions/sidebar_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698