Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: chrome/browser/extensions/extension_view_host_factory.h

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 9
10 class Browser; 10 class Browser;
(...skipping 10 matching lines...) Expand all
21 public: 21 public:
22 // Creates a new ExtensionHost with its associated view, grouping it in the 22 // Creates a new ExtensionHost with its associated view, grouping it in the
23 // appropriate SiteInstance (and therefore process) based on the URL and 23 // appropriate SiteInstance (and therefore process) based on the URL and
24 // profile. 24 // profile.
25 static ExtensionViewHost* CreatePopupHost(const GURL& url, Browser* browser); 25 static ExtensionViewHost* CreatePopupHost(const GURL& url, Browser* browser);
26 26
27 // Some dialogs may not be associated with a particular browser window and 27 // Some dialogs may not be associated with a particular browser window and
28 // hence only require a |profile|. 28 // hence only require a |profile|.
29 static ExtensionViewHost* CreateDialogHost(const GURL& url, Profile* profile); 29 static ExtensionViewHost* CreateDialogHost(const GURL& url, Profile* profile);
30 30
31 // Creates a new ExtensionHost with its associated view, grouping it in the
32 // appropriate SiteInstance (and therefore process) based on the URL and
33 // profile.
34 static ExtensionViewHost* CreateSidebarHost(const GURL& url,
35 Browser* browser);
36
31 private: 37 private:
32 DISALLOW_COPY_AND_ASSIGN(ExtensionViewHostFactory); 38 DISALLOW_COPY_AND_ASSIGN(ExtensionViewHostFactory);
33 }; 39 };
34 40
35 } // namespace extensions 41 } // namespace extensions
36 42
37 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_ 43 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_VIEW_HOST_FACTORY_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_view_host.cc ('k') | chrome/browser/extensions/extension_view_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698